Hi Johan On Tue, Apr 29, 2014 at 10:01 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi, > > On Tue, Apr 29, 2014, Lukasz Rymanowski wrote: >> +static void connect_event(GIOChannel *io, GError *gerr, void *user_data) >> +{ >> + struct gatt_device *dev = NULL; > fix in v2 > This looks like an unnecessary initialization upon declaration, looking > at how the variable is handled in the rest of the function. > >> + /*TODO: Attach to attrib db */ > > Space after /* fix in v2 > >> + if (listening_sk == NULL) { > > I think we're trying to make the coding style consistent by using > if (!ptr) > fix in v2 > Johan > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks Lukasz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html