Hi Marcel, On Tue, Feb 25, 2014, Marcel Holtmann wrote: > > - bool require_privacy; > > + bool connectable, require_privacy; > > > > - require_privacy = !test_bit(HCI_CONNECTABLE, &hdev->dev_flags); > > + connectable = get_connectable(hdev); > > + require_privacy = !connectable; > > > > if (hci_update_random_address(req, require_privacy, &own_addr_type) < 0) > > return; > > can we use a comment here to explain require_privacy like we do with > the other time it is used. the two variables are too much. And then > call it like this ..address(req, !connectable, &own..). Sure. v2 coming in a few minutes. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html