On Mon, Feb 17, 2014 at 11:01:11PM -0800, Marcel Holtmann wrote: > Hi Lucas, > > > Commit bfacbb9 (Bluetooth: Use devname:vhci module alias for virtual HCI > > driver) added the module alias to hci_vhci module so it's possible to > > create the /dev/vhci node. However creating an alias without > > specifying the minor doesn't allow us to create the node ahead, > > triggerring module auto-load when it's first accessed. > > > > Starting with depmod from kmod 16 we started to warn if there's a > > devname alias without specifying the major and minor. > > > > Let's do the same done for uhid, kvm, fuse and others, specifying a > > fixed minor. In systems with systemd as the init the following will > > happen: on early boot systemd will call "kmod static-nodes" to read > > /lib/modules/$(uname -r)/modules.devname and then create the nodes. When > > first accessed these "dead" nodes will trigger the module loading. > > > > Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > --- > > > > Changes from v1: > > - use minor=137, since 240 is reserved for local use > > > > We talked about using 197, but that's being used by pxa3xx-gcu, too. > > looks fine to me. If Kay and/or Greg want to ack it, then I take it through bluetooth-next tree. Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
