Hi Johan,
> Since we want user space to see and use the LE Identity Address whenever
> interfacing with the kernel it makes sense to track that instead of the
> real address (the two will only be different in the case of an RPA).
> This patch adds the necessary updates to when an LE connection gets
> established and when receiving the Identity Address from a remote
> device.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> ---
> net/bluetooth/hci_event.c | 7 +++++++
> net/bluetooth/smp.c | 3 +++
> 2 files changed, 10 insertions(+)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index d2c6878a9d6a..f31410a071b5 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -3568,6 +3568,7 @@ static void hci_le_conn_complete_evt(struct hci_dev *hdev, struct sk_buff *skb)
> {
> struct hci_ev_le_conn_complete *ev = (void *) skb->data;
> struct hci_conn *conn;
> + struct smp_irk *irk;
>
> BT_DBG("%s status 0x%2.2x", hdev->name, ev->status);
>
> @@ -3600,6 +3601,12 @@ static void hci_le_conn_complete_evt(struct hci_dev *hdev, struct sk_buff *skb)
> }
> }
>
> + irk = hci_get_irk(hdev, &ev->bdaddr, ev->bdaddr_type);
> + if (irk) {
> + bacpy(&conn->dst, &irk->bdaddr);
> + conn->dst_type = irk->addr_type;
> + }
> +
> if (ev->status) {
> mgmt_connect_failed(hdev, &conn->dst, conn->type,
> conn->dst_type, ev->status);
> diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
> index 54672c9ab6a5..4d14ccc7b330 100644
> --- a/net/bluetooth/smp.c
> +++ b/net/bluetooth/smp.c
> @@ -973,6 +973,9 @@ static int smp_cmd_ident_addr_info(struct l2cap_conn *conn,
> hci_add_irk(conn->hcon->hdev, &smp->id_addr, smp->id_addr_type,
> smp->irk, &rpa);
>
> + bacpy(&hcon->dst, &smp->id_addr);
> + hcon->dst_type = smp->id_addr_type;
> +
is this really safe to just overwrite the dst and dst_type. If we do that, we never really know the address that used for the actual connection.
For example what happens if now a stupid L2CAP connection gets intimated for the RPA or we have an incoming request for the same RPA. Can we really at this point say, we never need the RPA again?
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
