On Wed, 22 Jan 2014 11:16:20 -0400 Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx> wrote: > Hi Natanael, > > On Wed, Jan 22, 2014 at 9:50 AM, Natanael Copa <natanael.copa@xxxxxxxxx> wrote: > > diff --git a/src/textfile.h b/src/textfile.h > > index b779bd2..e26da5d 100644 > > --- a/src/textfile.h > > +++ b/src/textfile.h > > @@ -24,6 +24,8 @@ > > #ifndef __TEXTFILE_H > > #define __TEXTFILE_H > > > > +#include <sys/stat.h> > > + > > I believe the correct approach here is to include sys/stat.h on all > files that include textfile.h. We (usually) don't #include system > headers inside internal headers. The header itself uses mode_t: ./src/textfile.h:27:1: error: unknown type name 'mode_t' So all the files that include textfiles.h needs to include sys/stat.h *before* the include textfile.h in that case. I'd say that all filesm that uses mode_t including textfile.h should include sys/stat.h. I can make a new patch for either. Just let me know what you want. -nc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
