Hi Anderson, >> diff --git a/src/textfile.h b/src/textfile.h >> index b779bd2..e26da5d 100644 >> --- a/src/textfile.h >> +++ b/src/textfile.h >> @@ -24,6 +24,8 @@ >> #ifndef __TEXTFILE_H >> #define __TEXTFILE_H >> >> +#include <sys/stat.h> >> + > > I believe the correct approach here is to include sys/stat.h on all > files that include textfile.h. We (usually) don't #include system > headers inside internal headers. with code in src/shared/*.h we started to include the system headers that are required from the header, but you are correct, we don’t do that for internal src/*.h headers. Also we do not use circular inclusion protection from internal headers. So I ripped the stupid __TEXTFILE_H stuff out now. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
