From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> It is enough to check for zero in __sync_sub_and_fetch(). This makes code consistent like shown below: ./src/shared/mgmt.c: if (__sync_sub_and_fetch(&mgmt->ref_count, 1)) ./src/shared/pcap.c: if (__sync_sub_and_fetch(&pcap->ref_count, 1)) ./src/shared/btsnoop.c: if (__sync_sub_and_fetch(&btsnoop->ref_count, 1)) ./src/shared/hciemu.c: if (__sync_sub_and_fetch(&hciemu->ref_count, 1)) --- src/shared/hciemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/hciemu.c b/src/shared/hciemu.c index 0ea191f..c2b4748 100644 --- a/src/shared/hciemu.c +++ b/src/shared/hciemu.c @@ -341,7 +341,7 @@ void hciemu_unref(struct hciemu *hciemu) if (!hciemu) return; - if (__sync_sub_and_fetch(&hciemu->ref_count, 1) > 0) + if (__sync_sub_and_fetch(&hciemu->ref_count, 1)) return; g_list_foreach(hciemu->post_command_hooks, destroy_command_hook, NULL); -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
