Re: [PATCH] btusb: add realtek 8723 in the blacklist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bruce,

On Mon, Nov 04, 2013, Bruce.Ma wrote:
> From: Bruce Ma <bruce.ma@xxxxxxxxxxxxx>
> Date: Tue, 04 Nov 2013 11:21:20 +0800
> Subject: [PATCH] btusb: add Realtek 8723 in the blacklist
> 
> The btusb doesn't work with Realtek 8723 bluetooth device,
> so we want to add it to the blacklist.
> 
> Signed-off-by: Bruce Ma <bruce.ma@xxxxxxxxxxxxx>
> ---
>  drivers/bluetooth/btusb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index eae58a1..3097ac8 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -138,6 +138,9 @@ static struct usb_device_id blacklist_table[] = {
> 	{ USB_DEVICE(0x0489, 0xe03d), .driver_info = BTUSB_IGNORE },
> 	{ USB_DEVICE(0x0489, 0xe027), .driver_info = BTUSB_IGNORE },
> +	/* Realtek 8723 Bluetooth */
> +	{ USB_DEVICE(0x0bda, 0xb728), .driver_info = BTUSB_IGNORE },
> +
> 	/* Atheros AR9285 Malbec with sflash firmware */
> 	{ USB_DEVICE(0x03f0, 0x311d), .driver_info = BTUSB_IGNORE },
>  -- 1.8.1.2

I suppose after adding the device to the blacklist it still doesn't
work? :)

What I mean is, what's the value of this patch if the experience the
user gets is the same both with and without it? Wouldn't it make more
sense to put some effort into fixing btusb so that this hardware *does*
work with it, or alternatively providing a separate driver to support
the hardware (after which it *would* be ok to add the id to the btusb
blacklist).

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux