Re: [PATCHv5 0/7] Improve logging for Android

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Fri, Nov 01, 2013, Andrei Emeltchenko wrote:
> Logging on Android is really important since we do not have specification
> how and in which order hal functions are called, sometimes the only way is
> to examine logs or read Java Bluetooth code.
> 
> Changes:
> 	* v5: Rebased against latest upstream and merged some patches, added several logs.
> 	* v4: Rebased against latest upstream
> 	* v3: Merged first two patches.
> 	* v2: Added thread-safe helpers for printing properties, bdaddr, etc
> 	after comments that simple printing is not thread-safe. The idea is to
> 	use TLS (thread local storage) like bionic is doing for strerror for
> 	example. More info can be found on manpage for pthread_key_create.
> 
> This patch series uses debug functions defined already for haltest and
> allows to print very helpful logs on Android target like shown below:
> 
> ...
> hal-bluetooth.c:set_adapter_property() prop: type=BT_PROPERTY_ADAPTER_SCAN_MODE len=4 val=BT_SCAN_MODE_NONE
> ...
> 
> Andrei Emeltchenko (7):
>   android/haltest: Export print property
>   android/haltest: Use pointer as parameter for debug
>   android/haltest: Fix print device name
>   android/hal: Add extra logs to HAL
>   android: Add thread-safe helpers
>   android: Use thread-safe helpers
>   android/daemon: Add logs to trace failed cmd
> 
>  android/adapter.c         |    2 +
>  android/client/if-bt.c    |  111 +------------------------------------------
>  android/client/textconv.c |  114 +++++++++++++++++++++++++++++++++++++++++++++
>  android/client/textconv.h |    3 ++
>  android/hal-bluetooth.c   |   34 +++++++++-----
>  android/pthread-local.h   |   58 +++++++++++++++++++++++
>  6 files changed, 200 insertions(+), 122 deletions(-)
>  create mode 100644 android/pthread-local.h

Patches 1-4 and patch 7 (with a minor modification) have been applied.
Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux