Hi Andrei,
On Fri, Sep 27, 2013, Andrei Emeltchenko wrote:
> + sock = socket(AF_UNIX, SOCK_STREAM, 0);
> + if (sock < 0) {
> + error("%s: socket(): %s", __func__, strerror(errno));
> + return sock;
> + }
This should be SOCK_SEQPACKET. It has been mentioned several times in
our (offline) conversations and is also clearly stated in the IPC
document we'll soon push upstream.
> + /* Since daemon would be run also on host we have to grant perms */
> + chmod(sock_path, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH |
> + S_IWOTH);
Is this really necessary? On the host (by which I presume you mean the
system where you build BlueZ, i.e. a non-android system) couldn't the
test tool that's used just exec the daemon and then you have the same
context for both processes that need to access the socket.
> @@ -646,11 +648,13 @@ int main(int argc, char *argv[])
> exit(1);
>
> init_mgmt_interface();
> + start_hal_srv("/dev/socket/bluez_hal");
Isn't /var/run the right place for stuff like this? Alternatively we
could also go with an abstract socket and then not care about any
associations with the file system at all.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
