Hi Johan: > -----Original Message----- > From: Johan Hedberg [mailto:johan.hedberg@xxxxxxxxx] > Sent: Monday, July 15, 2013 17:51 > To: Xu, Martin > Cc: martin.xu@xxxxxxxxxxxxxxx; linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] Profile: fix set default exteranl profile > authorize > > Hi Martin, > > On Mon, Jul 15, 2013, Xu, Martin wrote: > > > > ext->sec_level = BT_IO_SEC_MEDIUM; > > > > - ext->authorize = true; > > > > ext->enable_client = true; > > > > ext->enable_server = true; > > > > ext->remote_uuid = NULL; > > > > > > The above change is still wrong. Not setting to true is the same as > > > setting to false since g_new0 was used. Don't change that part at a > > I can't find issue here > > I set the ext->authorize = settings->authorize so no matter the > > original value is, it will be just set as the same value with default > > setting. > > That's true, but what if the external profile is something that we > don't have a settings entry for? In that case ext->authorize will never > be explicitly set to anything. You are right, I will resent the patch. :) -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
