Hi Martin, On Mon, Jul 15, 2013, martin.xu@xxxxxxxxxxxxxxx wrote: > authorize is always set as "true" in function ext_set_defaults(). > > the static variable authorize of default_settings will be 0(false), > if it is not initialized. So item authorize needs to be initized if > the value is true (non-0). > And then function ext_set_defaults() can set default authorize properly > --- > src/profile.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) The subject says "PATCH 1/3". Did you intend to send three patches? I can only see this one. > @@ -1998,7 +2008,6 @@ static void ext_set_defaults(struct ext_profile *ext) > > ext->mode = BT_IO_MODE_BASIC; > ext->sec_level = BT_IO_SEC_MEDIUM; > - ext->authorize = true; > ext->enable_client = true; > ext->enable_server = true; > ext->remote_uuid = NULL; The above change is still wrong. Not setting to true is the same as setting to false since g_new0 was used. Don't change that part at all. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
