Hi Mikel, On Thu, May 23, 2013 at 9:21 AM, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > Hi Mikel, > > On Thu, May 23, 2013 at 2:28 AM, Mikel Astiz <mikel.astiz.oss@xxxxxxxxx> wrote: >> From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> >> >> This patchset addresses the issues reported by Alex Deymo in the thread "audio: Connect doesn't return when audio device is off". Extracted from his message: >> >> "There are two ways to hit this problem: >> * One is to attempt a connection when the device is off, >> * the other one is to attempt a connection from the host right after >> you short press the button with the bluetooth logo on the speakers. >> This button normally reconnects the speakers to the host, but if you >> attempt a connection while the device is also doing that, you end up >> in the same situation." >> >> I have been able to reproduce the first issue, which should be fixed with patch 1/4. The second issue is addressed in patch 3/4 but I couldn't actually test it. >> >> Patch 4/4 tries to improve the AVRCP role heuristic, which could alone fix Alex's issues, but I think the core cannot rely on this heuristic nevertheless. >> >> Mikel Astiz (4): >> avrcp: Fix missing reply to profile connect >> control: Remove unused parameter >> avrcp: Fix service connections not reported to core >> avrcp: Don't require active sink in role heuristic >> >> profiles/audio/avrcp.c | 17 ++++------------- >> profiles/audio/control.c | 37 +++++++++++++++++++++++++++---------- >> profiles/audio/control.h | 7 +++---- >> 3 files changed, 34 insertions(+), 27 deletions(-) >> >> -- >> 1.8.1.4 > > By looking at your patch 2/4 it seems we are not able to really tell > if a connection attempt has failed anymore, so I think there is > probably something wrong. The host down error should probably stop > continuing connection whenever it fails the first time, the issue with > the connection clash is probably different though and perhaps we > should go ahead with the heuristic fix and see if that fixes all the > problems. > > @Alex: Can you test the last patch from Mikel for the second issue > with the remote device connecting to us while we are connecting to it? > The host down I think Johan has been working on that and we should > have a patch soon. Actually let me take it back, the heuristic fix actually doesn't do anything since we already have the same check four line above this should never happen. A potential fix is to remove auto_connect from avrcp_target_profile so if sink fails to connect it won't connect automatically, anyway when the sink connects device.c will make sure to connect avrcp as well. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
