Re: [PATCH 1/1] profile: Fix incoming connections without SDP record

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On Tue, May 21, 2013 at 5:26 PM, Christian Fetzer
<christian.fetzer@xxxxxxxxxxxxxxxx> wrote:
> From: Christian Fetzer <christian.fetzer@xxxxxxxxxxxx>
>
> After commit 7bd3626b6715ac6a117d56b95b455960f7cf34de, incoming connections
> require the service being available from SDP. This is not always guaranteed
> because some services might not be listed in SDP (like MNS).
> ---
>  src/profile.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/profile.c b/src/profile.c
> index 8fd0424..9f98d65 100644
> --- a/src/profile.c
> +++ b/src/profile.c
> @@ -1056,6 +1056,7 @@ static struct ext_io *create_conn(struct ext_io *server, GIOChannel *io,
>                 return NULL;
>         }
>
> +       btd_device_add_uuid(device, server->ext->remote_uuid);
>         service = btd_device_get_service(device, server->ext->remote_uuid);
>         if (service == NULL) {
>                 ba2str(dst, addr);
> --

Ack from my side.

A comment might be helpful to clarify that the condition below (i.e.
service == NULL) is now unlikely and only possible due to issues
during profile probe.

Cheers,
Mikel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux