Re: [PATCH BlueZ 1/2] test: Remove commented out code from simple-agent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Fri, May 17, 2013 at 8:15 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Anderson,
>
>>>> --- a/test/simple-agent
>>>> +++ b/test/simple-agent
>>>> @@ -176,6 +176,3 @@ if __name__ == '__main__':
>>>>              manager.RequestDefaultAgent(path)
>>>>
>>>>      mainloop.run()
>>>> -
>>>> -     #adapter.UnregisterAgent(path)
>>>> -     #print("Agent unregistered")
>>>
>>> I would prefer if we remove the whole script. Does it provide anything that bluetoothctl is not providing?
>>
>> I have nothing against it (and we can always improve bluetoothctl if
>> something is missing there), but this is a legacy script that some
>> distros seem to package and users have been relying on it as a simple
>> console agent. Maybe we should (somehow) advertise bluetoothctl more.
>>
>> BTW, It seems that --timeout/-t option on simple-agent is totally ignored.
>
> then lets just delete it. Distros should be shipping bluetoothctl anyway these days.

Ultimately it is better to use bluetoothctl but it doesn't hurt to
have an example in python, but we should probably improve the
documentation about agent capabilities and IMO it should default to
"KeyboardDisplay" when no capability is given (agent on), right now I
think it does "" which maps to IO_CAPABILITY_DISPLAYYESNO.

--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux