Hi Fred, > When an incoming SCO connection is requested, check the selected voice setting, > and reply appropriately. Voice setting should have been negotiated previously. > For example, in case of HFP, the codec is negotiated using AT commands on the > RFCOMM channel. This patch only changes replies for socket with defered setup > enabled. > > Signed-off-by: Frédéric Dalleau <frederic.dalleau@xxxxxxxxxxxxxxx> > --- > net/bluetooth/sco.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c > index 7b4c3df..7881208 100644 > --- a/net/bluetooth/sco.c > +++ b/net/bluetooth/sco.c > @@ -653,7 +653,7 @@ static int sco_sock_sendmsg(struct kiocb *iocb, struct socket *sock, > return err; > } > > -static void sco_conn_defer_accept(struct hci_conn *conn) > +static void sco_conn_defer_accept(struct hci_conn *conn, int setting) > { > struct hci_dev *hdev = conn->hdev; > > @@ -676,9 +676,22 @@ static void sco_conn_defer_accept(struct hci_conn *conn) > > cp.tx_bandwidth = __constant_cpu_to_le32(0x00001f40); > cp.rx_bandwidth = __constant_cpu_to_le32(0x00001f40); > - cp.max_latency = __constant_cpu_to_le16(0xffff); > - cp.content_format = cpu_to_le16(hdev->voice_setting); > - cp.retrans_effort = 0xff; so we are now ignoring the hdev->voice_setting. This is fine for eSCO, but what are we doing in case we have a 1.1 controller that only supports the Add_SCO command? Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html