Re: [PATCH BlueZ 05/26] attrib: Get rid of guint* types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

On Thu, May 9, 2013 at 12:16 AM, Lucas De Marchi
<lucas.demarchi@xxxxxxxxxxxxxx> wrote:
> diff --git a/attrib/gatt.h b/attrib/gatt.h
> index 305b4c6..d5758b7 100644
> --- a/attrib/gatt.h
> +++ b/attrib/gatt.h
> @@ -22,6 +22,7 @@
>   *
>   */
>
> +#include <inttypes.h>
>  #include <bluetooth/sdp.h>

We used to avoid adding includes into headers, and instead add them on
the .c files only. (The existing include above is a unfortunate
exception). Not sure if this convention has changed since.

> diff --git a/attrib/gattrib.h b/attrib/gattrib.h
> index 3fe92c7..a1f2dd8 100644
> --- a/attrib/gattrib.h
> +++ b/attrib/gattrib.h
> @@ -28,6 +28,8 @@
>  extern "C" {
>  #endif
>
> +#include <inttypes.h>
> +
>  #define GATTRIB_ALL_EVENTS 0xFF
>  #define GATTRIB_ALL_REQS 0xFE
>  #define GATTRIB_ALL_HANDLES 0x0000

Same thing here.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux