Hi Johan, >> -gboolean g_attrib_set_destroy_function(GAttrib *attrib, >> - GDestroyNotify destroy, gpointer user_data) >> +bool g_attrib_set_destroy_function(GAttrib *attrib, GDestroyNotify destroy, >> + gpointer user_data) > > I've applied patches 1-5 but stopped there since I'm still not sure that > we want to change this for an API which tries to follow GLib conventions > (after all that's why the GAttrib API has G and g_ prefixes). Marcel, do > you have any opinion about this one way or another? the long term plan is to use standard types like bool, char, uint8_t and also void * here. However we might want to also see how to get rid of g_ prefix as well. Especially g_attrib seems to be a good candidate to get rid of. I also like to see ATT and GATT being implemented as src/shared/ under LGPL so we can be easily share it in the future. I already have some (unpublished) code for src/shared/att.[ch] and src/shared/gatt.[ch] already, but I think what we first need to do is to figure out how we handle clients and servers from the kernel side. Especially with the background of the kernel auto-connecting LE channels in the future. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
