Re: [PATCH v3 7/8] core: Expose the last bonding attempt timeout on retry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

>> +	gint64 attempt_start_time_us;
>> +	gint64 last_attempt_duration_us;
>> };
>> 
>> typedef enum {
>> @@ -1420,12 +1422,52 @@ static struct bonding_req *bonding_request_new(DBusMessage *msg,
>> 
>> 	bonding->capability = io_cap;
>> 
>> +	/* Marks the bonding start time for the first attempt on request
>> +	 * construction. The following attempts will be updated on
>> +	 * device_bonding_retry. */
>> +	bonding->attempt_start_time_us = g_get_monotonic_time();
> 
> Since we're in the long run aiming to remove the GLib dependency, I'm
> not so sure it's the best idea to add yet another dependency to a GLib
> feature. Would it be that much more complicated to just use libc
> directly for this? OTOH, if Marcel doesn't mind this new GLib API
> dependency I'm not gonna object to this patch.

or just use clock_gettime which should be the same anyway. We do rely on a recent kernel and glibc anyway.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux