Hi Alex,
On Tue, Apr 23, 2013, Alex Deymo wrote:
> +struct pincb_iter {
> + GSList *it; /* current callback function */
> + uint32_t attempt; /* numer of times it() was called */
Why specifically uint32_t? We usually reserve fixed size integer types
for stuff that directly maps to a protocol that really requires it,
whereas for simple iterators "int" should be enough.
> + iter = device_bonding_iter(device);
> +
> + if (iter == NULL)
Remove the empty line above. When doing an assignment to a variable and
then testing the variable's value we don't have any empty lines in
between.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
