Hi Johan, >>> + const u8 *patch_curr; >>> + char pfile[32]; >>> + u8 *m_off_code; >>> + >>> + u8 m_on[] = { 0x01, 0x00 }; >>> + u8 m_off_1[] = { 0x00, 0x01 }; >>> + u8 m_off_2[] = { 0x00, 0x02 }; >> >> Shouldn't this be __u8. Johan, any preference. I know that I used __u8 >> for the bcm92035 vendor command. > > To my understanding __u8 (and __u16 and __u32 too) are intended for code > that's to be shared with user space (e.g. our upcoming uapi header > file(s)). Anything else should just use u8. At least this is what I > discovered after some research when I get more heavily involved with > kernel development a few years ago. then you might have to tweak my other patch a little to fix this for BCM92035 setup routine. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html