Hi Marcel,
On 03/11/2013 05:19 PM, Marcel Holtmann wrote:
Hi Christian,
This allows applications to register for all different types
of MAP event reports.
In response to this call, the MSE should connect to the local MNS
instance.
---
doc/obex-api.txt | 6 ++++
obexd/client/map.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 92 insertions(+)
never ever intermix doc/ changes with actual code. You really need to learn on how to split patches properly. There is no reason at all that this are not two patches.
diff --git a/doc/obex-api.txt b/doc/obex-api.txt
index 759c4d8..ef5d85e 100644
--- a/doc/obex-api.txt
+++ b/doc/obex-api.txt
@@ -651,6 +651,12 @@ Methods void SetFolder(string name)
Possible errors: org.bluez.obex.Error.InvalidArguments
org.bluez.obex.Error.Failed
+ void RegisterNotifications(boolean)
+
+ Register / unregister reception of notifications.
+
+ Possible errors: org.bluez.obex.Error.InvalidArguments
+ org.bluez.obex.Error.Failed
Why don't you describe the boolean variable and what it does. If this is an on/off switch, then we are not doing this stupid thing here.
Simple things like EnableNotifications and DisableNotifications would be better. Also this needs a bit detailed explanations why you thing this is the right API for handling this. I am not even convinced we should be doing it like this.
Regards
Marcel
Thanks for your comments. I'll split the patches and send an updated
patch set.
Yes, RegisterNotification simply enables / disabled receiving event
reports. I can change it as suggested.
The reason for having an API function instead of enabling it implicitly
is that the application can control
for which device it wants to receive event reports.
Event reports can be received for multiple MAP sessions on the same device.
This is used for example when the phone exposes different E-Mail
accounts as different MAP instances.
But according to the specification, we need to have one MNS (obex
server) instance for each remote device.
The current code is limited to exactly one static MNS instance, and you
can receive notifications only for one device.
In the future we could eventually work around that limitation by
dynamically instantiating MNS instances when
needed.
Br,
Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
