Hi Christian, > This allows applications to register for all different types > of MAP event reports. > > In response to this call, the MSE should connect to the local MNS > instance. > --- > doc/obex-api.txt | 6 ++++ > obexd/client/map.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 92 insertions(+) never ever intermix doc/ changes with actual code. You really need to learn on how to split patches properly. There is no reason at all that this are not two patches. > diff --git a/doc/obex-api.txt b/doc/obex-api.txt > index 759c4d8..ef5d85e 100644 > --- a/doc/obex-api.txt > +++ b/doc/obex-api.txt > @@ -651,6 +651,12 @@ Methods void SetFolder(string name) > Possible errors: org.bluez.obex.Error.InvalidArguments > org.bluez.obex.Error.Failed > > + void RegisterNotifications(boolean) > + > + Register / unregister reception of notifications. > + > + Possible errors: org.bluez.obex.Error.InvalidArguments > + org.bluez.obex.Error.Failed Why don't you describe the boolean variable and what it does. If this is an on/off switch, then we are not doing this stupid thing here. Simple things like EnableNotifications and DisableNotifications would be better. Also this needs a bit detailed explanations why you thing this is the right API for handling this. I am not even convinced we should be doing it like this. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
