Re: [PATCH 4/5] adaptername: Remove not needed empty remove callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

On Mon, Nov 26, 2012 at 6:52 AM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote:
> On Monday 26 of November 2012 12:45:30 Anderson Lizardo wrote:
>> Hi Szymon,
>
> Hi Anderson,
>
>>
>> On Mon, Nov 26, 2012 at 5:07 AM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote:
>> >  static struct btd_adapter_driver adaptername_driver = {
>> >         .name   = "adaptername",
>> >         .probe  = adaptername_probe,
>> > -       .remove = adaptername_remove,
>> > +       .remove = NULL,
>> >  };
>>
>> This variable is static, so not explicitly initialized members will be NULL.
>
> Yes, yet according to code style for bluez statics should be initialized
> explicitly, right? Or this does not count for struct members?

I forgot to mention that I did run this:

egrep -r '^[[:space:]]*\.[a-z_]+[[:space:]]*=.*NULL' *

with no results, which means no other structs are initializing unused
members with NULL. But you are right that we are still initializing
non-compound static variables explicitly to NULL or 0, as per
convention.

Best Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux