Re: [PATCH 8/8] neard: Set device class in device object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frédéric,

On Thu, Nov 15, 2012, Frédéric Danis wrote:
> This will create a new device object and generate DeviceCreated signal
> ---
>  plugins/neard.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Your commit message doesn't explain why the old object needs to be
removed (imo it shouldn't need to be removed).

The other patches in this set have been applied.

> +	device = adapter_get_device(adapter, remote_address);
> +
>  	/* store OOB data */

Missing check for failed adapter_get_device() return (NULL).

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux