On Wed, 14 Nov 2012 23:50:55 +0900 Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Fred, > > > > v4 integrate latest comments from Siarhei: > > > - remove state->pending field from sbc_encoder_state > > > - add armv6 and iwmmxt primitives > > > - use simd primitive instead of neon > > > - reorder patches so that the SBC_MSBC flag is exposed to users only when > > > implementation is complete. > > > > Any feedback ? > > beside a tiny cosmetic comment, I have nothing. However I am not the > expert here. If Siarhei looks over this and is fine with it, I will be > as well. Hi, My biggest concern is the way how we handle the mSBC API/ABI extension. Because once the new version of sbc library is out, we can't (easily/painlessly) change it any more. Everything else is fixable. Anyway, as far as I can see, there are no regressions in the existing SBC functionality, which is the most important requirement. I personally would prefer a bit more verbose commit messages. But let me know if these demands are unreasonable :) -- Best regards, Siarhei Siamashka -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
