Hi Siarhei, Thanks for review, I mostly agree but have a few remarks. On Sun, Oct 28, 2012 at 12:19 AM, Siarhei Siamashka <siarhei.siamashka@xxxxxxxxx> wrote: > On Fri, 26 Oct 2012 19:20:30 +0200 > If "position" was not decremented by 16 for 8 samples here, then you > would not need to do > if (state->pending == state->position) > x += 8; > elsewhere. Good idea, just note that in this case, one sample (x[1] = PCM(0 + 7 * nchannels)) will receive a negative index x[-7]. there is no technical problème just a matter of style. > One more nitpick about "sbc_encoder_process_input_s8". The old > variant was taking "position" as a function argument and returning > an updated position. Addtionnally, sbc_encoder_process_input_s8 would return void, and state->position would be used directly from process_input function. However, it requires changes in the neon code, which I'd rather avoid for now. I can send a patch later for this one. Regards, Frédéric -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
