Hi Lizardo, On Tue, Oct 23, 2012, Anderson Lizardo wrote: > On Tue, Oct 23, 2012 at 12:53 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > > + if (hdev->adv_tx_power) { > > + ptr[0] = 2; > > + ptr[1] = EIR_TX_POWER; > > + ptr[2] = (u8) hdev->adv_tx_power; > > + > > + ad_len += 3; > > + ptr += 3; > > + } > > 0dBm is a valid TX power. Not sure the if() clause is valid here. If it's not, we'd need to extend the storage size of hdev->adv_tx_power (to have some invalid value) or add another variable to hdev to indicate that we know the tx_power. FWIW, create_eir also uses the same test for including the inq_tx_power, so either both or neither should be fixed. For simplicity I'd just keep the 0-test unless 0 is a really common value. > Also, I'm worried how we are going to put other advertising data here, > i.e. Manufacturer Specific data or Service Data. On last BlueZ meeting > we proposed (and have been implementing) the Set Controller Data mgmt > command to set them. Is this still an acceptable approach? Yes, though we only have 31 bytes to play with here which is quite little. Also, we might want to make this dependent on the LE GAP role. E.g. we might be more interested in manufacturer specific data for broadcaster role than for peripheral role (maybe a user space application *only* wants its data for broadcaster role). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html