Hi Johan, On Tue, Oct 23, 2012 at 12:53 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > + if (hdev->adv_tx_power) { > + ptr[0] = 2; > + ptr[1] = EIR_TX_POWER; > + ptr[2] = (u8) hdev->adv_tx_power; > + > + ad_len += 3; > + ptr += 3; > + } 0dBm is a valid TX power. Not sure the if() clause is valid here. Also, I'm worried how we are going to put other advertising data here, i.e. Manufacturer Specific data or Service Data. On last BlueZ meeting we proposed (and have been implementing) the Set Controller Data mgmt command to set them. Is this still an acceptable approach? Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html