Hi Marcel, On Mon, Oct 8, 2012 at 3:43 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Luiz, > >> This adds a fallback for GetProperties method when it is not >> implemented. >> --- >> This set of patches are workarounds to old properties interface to be able to >> test new code until other components are ported. > > I am not sure I want this at all. This is a nasty hack. > > Especially since interfaces that previously had neither or only some of > these methods get these methods. Bad idea. It might work inside BlueZ > where we always added these methods, but in other projects some of these > methods had been left out since the properties where send via signals > with the object path being announced. Yep, I fully agree this is not meant to be upstream (only perhaps behind a compilation flag or something like that), also this does not work with clients which do use the introspection data like dbus-python because the fallback methods are not part of it the python scripts will just fail. The purpose of these patches is for testing the new code with components such as PulseAudio, oFono, Connman and gnome-shell as we move forward and finish the changes they should no longer be necessary. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
