Re: [RFCv2 08/20] Bluetooth: AMP: Remote AMP ctrl definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Tue, Jul 24, 2012 at 06:13:42PM -0300, Gustavo Padovan wrote:
> > diff --git a/include/net/bluetooth/a2mp.h b/include/net/bluetooth/a2mp.h
> > index 012f573..8ba236c 100644
> > --- a/include/net/bluetooth/a2mp.h
> > +++ b/include/net/bluetooth/a2mp.h
> > @@ -29,6 +29,9 @@ struct amp_mgr {
> >  
> >  	struct list_head	phy_links;
> >  	struct mutex		phy_links_lock;
> > +
> > +	struct list_head	amp_ctrls;
> > +	struct mutex		amp_ctrls_lock;
> 
> Have you checked for RCU here, are they worthwhile? and why is it better than
> spinlocks?  This is for both locks above.

I want to be able to sleep inside critical section and using RCU is
overkill here.

Best regards 
Andrei Emeltchenko 
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux