Re: [RFCv2 08/20] Bluetooth: AMP: Remote AMP ctrl definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Andrei Emeltchenko <Andrei.Emeltchenko.news@xxxxxxxxx> [2012-07-24 16:21:49 +0300]:

> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> 
> Create remote AMP controllers structure. It is used to keep information
> about discovered remote AMP controllers by A2MP protocol.
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> ---
>  include/net/bluetooth/a2mp.h |    3 ++
>  include/net/bluetooth/pal.h  |   14 ++++++++
>  net/bluetooth/a2mp.c         |    5 +++
>  net/bluetooth/pal.c          |   81 ++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 103 insertions(+)
> 
> diff --git a/include/net/bluetooth/a2mp.h b/include/net/bluetooth/a2mp.h
> index 012f573..8ba236c 100644
> --- a/include/net/bluetooth/a2mp.h
> +++ b/include/net/bluetooth/a2mp.h
> @@ -29,6 +29,9 @@ struct amp_mgr {
>  
>  	struct list_head	phy_links;
>  	struct mutex		phy_links_lock;
> +
> +	struct list_head	amp_ctrls;
> +	struct mutex		amp_ctrls_lock;

Have you checked for RCU here, are they worthwhile? and why is it better than
spinlocks?  This is for both locks above.

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux