Hi On Fri, Jul 20, 2012 at 6:29 PM, Nathaniel Haggard <natester@xxxxxxxxx> wrote: > Patch to add generichid so bluez can emulate a bluetooth keyboard. > Pairs with ubuntu, osx leopard and tiger. The following commands set > it up for testing: Why calling it "generichid"? It took me quite some time to figure out what you actually implement here. If the profile is called "generichid" then this is fine, but please use more descriptive commit-messages. I guess this implements the client-side of the BT-HID specs? Furthermore, I think the input modules got moved into profiles/input/ so it would be nice if you could rebuild against the current git revision. And as a last point, please use more review-friendly splits. You currently introduce many functions in the first commit that aren't really used there. This makes review very hard. And a separate dbus-API description would be nice so we know what is actually implemented. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
