Hi Gustavo,
On Fri, Jun 01, 2012, Gustavo Padovan wrote:
> * Jefferson Delfes <jefferson.delfes@xxxxxxxxxxxxx> [2012-06-01 15:05:25 -0400]:
>
> > Change flags field to matches userspace structure.
> > This field needs to be converted to little endian before forward it.
> >
> > Signed-off-by: Jefferson Delfes <jefferson.delfes@xxxxxxxxxxxxx>
> > ---
> > include/net/bluetooth/mgmt.h | 2 +-
> > net/bluetooth/mgmt.c | 5 +++--
> > 2 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> > index ebfd91f..3a8a714 100644
> > --- a/include/net/bluetooth/mgmt.h
> > +++ b/include/net/bluetooth/mgmt.h
> > @@ -435,7 +435,7 @@ struct mgmt_ev_auth_failed {
> > struct mgmt_ev_device_found {
> > struct mgmt_addr_info addr;
> > __s8 rssi;
> > - __u8 flags[4];
> > + __le32 flags;
>
> Seems we are breaking API here, MGMT API is stable now and should have such
> kind of change. However I wanna see what Marcel and Johan has to say about
> this.
I don't see how this is breaking anything. The exact same bytes in the
same order would be transmitted through the mgmt socket. Or am I missing
something?
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
