Re: [RFC 1/8] Bluetooth: Move clean up code and set of SOCK_ZAPPED to l2cap_sock.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Gustavo Padovan <gustavo@xxxxxxxxxxx> [2012-05-24 13:56:11 -0300]:

> > >  
> > > +static void l2cap_sock_finalize_cb(void *data, int err)
> > > +{
> > > +	struct sock *sk = data;
> > 
> > Why we cannot just use l2cap_sock_finalize_cb(struct sock *sk, int err)
> > what is the reason for extra assignment?
> 
> Because we want to be generic here, we don't know who else will use finalize()
> so we need to keep a void * here.
> 
> > 
> > I also think finalize is not good name since it does not mean what is
> > actually finalized.
> 
> And it is not, I failed to come with a better name here. The initial one was
> delete, even worse.

Maybe we can go with prepare_finalize() or prepare_close() here.

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux