Re: [PATCH 1/2] AVRCP: Refactor the code using constants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joohi,

On Fri, May 18, 2012, joohi.rastogi@xxxxxxxxxxxxxx wrote:
> ---
>  audio/avrcp.c |   17 +++++++++++++++--
>  1 files changed, 15 insertions(+), 2 deletions(-)

You'll need to rebase this patch latest git since it doesn't apply
anymore. Additionally there were some issues:

> +	uint16_t avrcp_ver = 0x0100, avctp_ver = 0x0103;
> +	uint16_t feat = ( AVRCP_FEATURE_CATEGORY_1 |
> +			AVRCP_FEATURE_CATEGORY_2 |
> +			AVRCP_FEATURE_CATEGORY_3 |
> +			AVRCP_FEATURE_CATEGORY_4 );

This doesn't look like it's correctly indented. Split lines should be
indented as much as possible while staying under 80 characters.

> -	uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103, feat = 0x000f;
> +	uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103;
> +	uint16_t feat = ( AVRCP_FEATURE_CATEGORY_1 |
> +                        AVRCP_FEATURE_CATEGORY_2 |
> +                        AVRCP_FEATURE_CATEGORY_3 |
> +                        AVRCP_FEATURE_CATEGORY_4 );

Same here.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux