Hi Luiz,
On Fri, May 18, 2012, Johan Hedberg wrote:
> Hi Luiz,
>
> I think the following loop can be simplified a bit:
>
> > + for (l = session->handlers; l; l = l->next) {
> > + struct avctp_rsp_handler *handler = l->data;
> > +
> > + if (handler->id == avctp->transaction) {
>
> Avoid unnecessary indentation by using != and continue;
>
> > + gboolean ret = FALSE;
> > +
> > + if (handler->func)
> > + ret = handler->func(session, avc->code,
> > + avc->subunit_type,
> > + operands, operand_count,
> > + handler->user_data);
> > +
> > + if (ret)
> > + return;
>
> Once you've reduced the indentation by the above trick you could even
> just do:
>
> if (handler->func && handler->func(...))
> return;
I went ahead and cleaned this up myself along with a couple of other
coding style issues with the patch and pushed all three upstream.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
