Re: [PATCHv3 0/8] Support for displaying PIN for entry into device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Scott,

On Thu, Apr 05, 2012, Scott James Remnant wrote:
> Rationale: The Bluetooth HID specification recommends that keyboards be
> paired by generating a PIN on the host and displaying it for entry into
> the pairing keyboard. This is also the case for other kinds of devices,
> for example the GNOME Bluetooth wizard does something similar for the
> CMT-DH5BT audio device.
> 
> Current deployments, such as GNOME Bluetooth and Android, perform this
> generation inside the Agent which means each has to implement their
> own code to do the same thing. The intent of this patch is to move this
> common behavior into BlueZ so all can benefit.
> 
> My previous patch set performed this generation inside bluetoothd
> itself, this new version assumes that a plugin will do it and simply
> provides the mechanism for doing so.
> 
> I've also dropped the bt_ids header from the set.
> 
> Scott James Remnant (8):
>   Rename AUTH_TYPE_NOTIFY to AUTH_TYPE_NOTIFY_PASSKEY
>   Pass passkey by pointer rather than by value
>   agent: add DisplayPinCode method
>   Add AUTH_TYPE_NOTIFY_PASSKEY to device_request_authentication
>   Add display parameter to plugin pincode callback
>   Display PIN generated by plugin
>   doc: document DisplayPinCode
>   simple-agent: add DisplayPinCode
> 
>  doc/agent-api.txt |   24 +++++++++++
>  plugins/wiimote.c |    2 +-
>  src/adapter.c     |    4 +-
>  src/adapter.h     |    4 +-
>  src/agent.c       |  112 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  src/agent.h       |    4 ++
>  src/device.c      |   72 ++++++++++++++++++++++++++++++----
>  src/device.h      |    5 +-
>  src/event.c       |   18 ++++++---
>  test/simple-agent |    5 ++
>  10 files changed, 228 insertions(+), 22 deletions(-)

All patches in this set have been applied upstream. There were a few
coding style issues I fixed myself while applying (incorrect tabbing for
line splits and missing spaces in type casts) but other than that I
didn't find anything to object to. Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux