Hi Mikel,
On Tue, Apr 10, 2012 at 4:38 PM, Mikel Astiz <mikel.astiz.oss@xxxxxxxxx> wrote:
> From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx>
>
> The progress report in put_xfer_progress was done before the
> corresponding field was updated.
> ---
> client/transfer.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/client/transfer.c b/client/transfer.c
> index 3b4f8f2..b558d84 100644
> --- a/client/transfer.c
> +++ b/client/transfer.c
> @@ -494,10 +494,10 @@ static gssize put_xfer_progress(void *buf, gsize len, gpointer user_data)
> if (size <= 0)
> return size;
>
> - transfer_notify_progress(transfer);
> -
> transfer->transferred += size;
>
> + transfer_notify_progress(transfer);
> +
> return size;
> }
>
> --
> 1.7.7.6
git blame indicates this has been there in the past but it was changed
by this commit:
commit e1891acc03a22cc59f0dfb29869243f3ca81e716
Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
Date: Mon Oct 3 18:43:16 2011 +0300
Fix possible crash when indicating progress
The amount of transferred bytes should only be updated after it has
been sent.
It may not crash anymore, but the change is still logically correct
since the data has yet to be sent.
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
