Hi Mikel, Marcel, On Wed, Apr 11, 2012 at 12:24 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Mikel, > >> This patch refactors the SCO scheduling algorithm to remove code that is >> not making any difference. There is no HCI SCO flow control in the >> kernel so the scheduling can be simplified. >> >> All data produced by userspace is sent to the controller without any >> flow control. This was also the case before this patch, but now it's >> more obvious and readable. > > as in the previous patch. You can only do this if you make sure that the > controller does not have flow control enabled. You need another basic > check here to ensure this first. Otherwise a lot of things might break. It also seems to remove any quote/fairness of the scheduling, actually Im not sure how it works because it sends the frames regardless of the number of available slots/buffers indicated by sco_cnt, I also wonder how it will scale with multiple SCO connections, even though it is quite rare to have more than one who knows what crazy ideas people will come. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
