Hi Chen, On Mon, Mar 26, 2012 at 8:45 AM, <chen.ganir@xxxxxx> wrote: > From: Chen Ganir <chen.ganir@xxxxxx> > > Add Device Information Service GATT Client for reading peer > device PNP_ID and store it. > > Chen Ganir (5): > Add DeviceInformation GATT Client > DeviceInfo: Add connection logic > DeviceInfo: Discover Characteristics > Fix device version in GetProperties > DeviceInfo: Read PNP ID > > Makefile.am | 9 ++- > deviceinfo/deviceinfo.c | 218 +++++++++++++++++++++++++++++++++++++++++++++++ > deviceinfo/deviceinfo.h | 24 +++++ > deviceinfo/main.c | 55 ++++++++++++ > deviceinfo/manager.c | 82 ++++++++++++++++++ > deviceinfo/manager.h | 24 +++++ > src/device.c | 35 +++++++- > src/device.h | 3 + > 8 files changed, 446 insertions(+), 4 deletions(-) > create mode 100644 deviceinfo/deviceinfo.c > create mode 100644 deviceinfo/deviceinfo.h > create mode 100644 deviceinfo/main.c > create mode 100644 deviceinfo/manager.c > create mode 100644 deviceinfo/manager.h Except for the build error, I see no other issues on the GATT part of these patches. Someone else needs to review/comment on the part touching src/device.c though (maybe Johan himself?) Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html