On Tue, Mar 20, 2012 at 19:36, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Arik, > > On Mon, Mar 19, 2012, Arik Nemtsov wrote: >> - uint8_t (*read_cb)(struct attribute *a, gpointer user_data); >> - uint8_t (*write_cb)(struct attribute *a, gpointer user_data); >> + uint8_t (*read_cb)(struct attribute *a, gpointer user_data, >> + gpointer device); >> + uint8_t (*write_cb)(struct attribute *a, gpointer user_data, >> + gpointer device); > > Why is device a gpointer and not a struct btd_device *? Well att.h is a self contained include file (also used in gatttool for example). That means there would have to be at least a forward declaration for btd_device. If we go down that road, it gets tricky, since we depend on the include order of att.h and device.h. This can maybe be solved with ifdef tricks, but I thinking leaving att.h self contained is the better option here. Thoughts? > > Also, user_data should be the last parameter as per GLib conventions. Sure. I can change this. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
