Re: [PATCH v4 1/6] att: add remote btd_device to ATT read/write callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arik,

On Mon, Mar 19, 2012, Arik Nemtsov wrote:
> -	uint8_t (*read_cb)(struct attribute *a, gpointer user_data);
> -	uint8_t (*write_cb)(struct attribute *a, gpointer user_data);
> +	uint8_t (*read_cb)(struct attribute *a, gpointer user_data,
> +				gpointer device);
> +	uint8_t (*write_cb)(struct attribute *a, gpointer user_data,
> +				gpointer device);

Why is device a gpointer and not a struct btd_device *?

Also, user_data should be the last parameter as per GLib conventions.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux