Hi Arik, On Thu, Mar 15, 2012 at 8:17 AM, Arik Nemtsov <arik@xxxxxxxxxx> wrote: >>> + .name = "Proximity GATT Reporter Device Tracker Driver", >> >> And "Proximity GATT Reporter Device Driver" >> >>> + .uuids = BTD_UUIDS(GATT_UUID), >>> + .probe = gatt_device_probe, >>> + .remove = gatt_device_remove, >> >> And using reporter_probe() / reporter_remove() > > This is very similar to reporter_init()/reporter_exit() defined for in > reporter_server_driver, and the distinction is not clear. How about > reporter_device_probe/remove? Well, these functions are static anyway, so it is no problem that they are similarly named (IMHO) within other Proximity files. My concern is just that "gatt_device_" prefix is too generic and may be confusing. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
