On Thu, Mar 15, 2012 at 14:08, Anderson Lizardo
<anderson.lizardo@xxxxxxxxxxxxx> wrote:
> Hi Arik,
>
> On Thu, Mar 15, 2012 at 6:49 AM, Arik Nemtsov <arik@xxxxxxxxxx> wrote:
>> Register a D-Bus interface per remote device. Set a watch on the
>> "DeviceAdded" signal to add all existing devices. Likewise set watches
>> on "DeviceCreated" and "DeviceRemoved" to handle dynamic addition and
>> removal of devices.
>
> The paragraph above does not apply anymore. You need to update to
> refer to the device driver.
Ah you're right i'll update the description.
>
>> +/* device driver for tracking remote GATT client devices */
>> +static struct btd_device_driver reporter_dev_tracker_driver = {
>
> What about using "reporter_device_driver"
Well I wanted to avoid confusion with the "reporter_server_driver"
defined in proximity/manager.c. But I guess your proposition works as
well.
>
>> + .name = "Proximity GATT Reporter Device Tracker Driver",
>
> And "Proximity GATT Reporter Device Driver"
>
>> + .uuids = BTD_UUIDS(GATT_UUID),
>> + .probe = gatt_device_probe,
>> + .remove = gatt_device_remove,
>
> And using reporter_probe() / reporter_remove()
This is very similar to reporter_init()/reporter_exit() defined for in
reporter_server_driver, and the distinction is not clear. How about
reporter_device_probe/remove?
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
