Hi Mikel, On Tue, Mar 13, 2012, Mikel Astiz wrote: > From: Mikel Astiz <mikel.astiz@xxxxxxxxxxxx> > > audio_adapter_get() increases the reference counter of the adapter, so > it's necessary to decrement it in case of error. > --- > audio/manager.c | 22 +++++++++++++++++++--- > 1 files changed, 19 insertions(+), 3 deletions(-) Please test at least that your patches compile before submitting them: CC audio/bluetoothd-manager.o audio/manager.c: In function ‘avrcp_server_probe’: audio/manager.c:1058:2: error: ‘err’ undeclared (first use in this function) audio/manager.c:1058:2: note: each undeclared identifier is reported only once for each function it appears in audio/manager.c: In function ‘avrcp_server_remove’: audio/manager.c:1070:6: error: unused variable ‘err’ [-Werror=unused-variable] audio/manager.c: In function ‘avrcp_server_probe’: audio/manager.c:1063:1: error: control reaches end of non-void function [-Werror=return-type] Also: > --- a/audio/manager.c > +++ b/audio/manager.c > @@ -877,6 +877,7 @@ static void audio_adapter_unref(struct audio_adapter *adp) > return; > > adapters = g_slist_remove(adapters, adp); > + > btd_adapter_unref(adp->btd_adapter); > g_free(adp); > } This added line seems completely unrelated to the patch. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
