Re: [PATCHv1 12/14] Bluetooth: Change locking logic in security_cfm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Tue, Feb 21, 2012 at 6:44 PM, Andrei Emeltchenko
<andrei.emeltchenko.news@xxxxxxxxx> wrote:
> Hi Gustavo,
>
> On Tue, Feb 21, 2012 at 7:56 PM, Gustavo Padovan <padovan@xxxxxxxxxxxxxx> wrote:
>> * Andrei Emeltchenko <Andrei.Emeltchenko.news@xxxxxxxxx> [2012-02-21 12:55:05 +0200]:
>>
>>> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>>>
>>> Change bh_ locking functions to mutex_locks since we can now sleep.
>>>
>>> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>
>> I don't like the idea of this locking change in multiple separate patches, it
>> could put the stack in a broken and racy state if we stop in the middle of
>> these patches.
>> I would say to merge all these patches into one, they were a lot reviewed
>> alone, there is no problem in create a big one with all the changes together.
>
> I saw the same comments from Ulisses. I will merge all those patches
> together and send new patch series.

Well, yes, but Marcel wasn't really worried about it, though. It's
good if we merge this soon and move on with other patches touching
L2CAP code.

Best regards,

-- 
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux