Hi Ulisses, On Mon, Feb 20, 2012 at 09:55:35AM -0200, Ulisses Furquim wrote: > > >> With patch 3 you add some needed changes but then adds an imbalance of > >> lock/release sock locks which is only solved in patch 4. Why? > > > > How does patch 4 solves locking? If I did not miss something it shall > > not change anything. > > For instance, in patch 3 you replace l2cap_get_chan_by_scid() with __ > l2cap_get_chan_by_scid() in l2cap_connect_rsp(). However, __ > l2cap_get_chan_by_scid() doesn't lock_sock() as the other one did and > only in patch 4 you add an explicit lock_sock() to > l2cap_connect_rsp(). Got it? A commit should be self contained as much > as possible so we keep the code bisectable. You are right here, I will squash those mentioned patches since this is easy way. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
