Hi Johan, On Sun, Feb 19, 2012 at 7:51 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Andre, > > On Fri, Feb 17, 2012, Andre Guedes wrote: >> This RFCv2 series implements Marcel's and Johan's comments from previous >> version. The changes are: >> 1. Use MGMT_ADDR_* macros instead of hard-coded values to define discovery >> type macros; >> 2. Fix locking in mgmt_interleaved_discovery >> >> Marcel, I removed your ack from patch 1/4 because I changed it a little >> bit. MGMT_ADDR_* macros were moved to hci_core.h since they are needed to >> define discovery type macros. > > All four patches have been applied to my bluetooth-next tree. Thanks. > > I'd still like to have consistency in the locking since now your > function is the only one handling the hdev lock by itself and that's > something that can easily cause bugs in the long run. I.e. probably all > mgmt_* functions should be converted to take hdev unlocked and handle > the locking by themselves. Do you think such a change is worth? I'm not sure if we have just one function that deals with locking on its own. Regards, -- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
