Hi all, On Sun, Feb 05, 2012 at 11:12:10AM -0800, Marcel Holtmann wrote: > Hi Al, > > > For one thing, it's big. For another, the only caller is in a different > > file anyway... > > > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > > > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > > index 68f5891..124f7cf 100644 > > --- a/include/net/bluetooth/l2cap.h > > +++ b/include/net/bluetooth/l2cap.h > > @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid); > > struct l2cap_chan *l2cap_chan_create(struct sock *sk); > > void l2cap_chan_close(struct l2cap_chan *chan, int reason); > > void l2cap_chan_destroy(struct l2cap_chan *chan); > > -inline int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, > > +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, > > bdaddr_t *dst); > > I have no idea on how that happened, but you are fully correct this is > pointless. > > Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> Similar patch has been already applied a month ago to our bluetooth tree commit 79aa1a3322cfa65199a0d87eacd41bd1fbc33a1d Author: Johan Hedberg <johan.hedberg@xxxxxxxxx> Date: Sun Jan 8 22:51:16 2012 +0200 Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
